Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cometbft not up to date #1490

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 28, 2024

Solution:

  • update cometbft

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Updated the cometbft dependency to version 0.38.8.
    • Added a new indirect dependency: github.com/hashicorp/golang-lru/v2 version 2.0.7.

Solution:
- update cometbft
@yihuang yihuang requested a review from a team as a code owner June 28, 2024 01:21
@yihuang yihuang requested review from mmsqe and leejw51crypto and removed request for a team June 28, 2024 01:21
Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

The updates primarily consist of bumping the cometbft dependency in the crypto-org-chain/cronos project from version 0.38.7 to 0.38.8, and introducing a new indirect dependency on github.com/hashicorp/golang-lru/v2 at version v2.0.7. These changes ensure compatibility and improved performance.

Changes

Files Change Summary
CHANGELOG.md Added a summary of updating cometbft to version 0.38.8 in crypto-org-chain/cronos.
go.mod Updated cometbft from v0.38.7 to v0.38.8 and added hashicorp/golang-lru/v2 as an indirect dependency.
gomod2nix.toml Changed versions and hashes for cometbft and hashicorp/golang-lru/v2.

Sequence Diagram(s)

Not applicable for these changes.

Poem

In the code's whisper, changes glide,
Cometbft takes a stride,
Hashicorp's LRU joins the ride,
Dependencies now side by side.
Bugs and glitches we now deride,
In harmony, our project will bide.
🐇🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f1da23 and c3fad12.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • go.mod (2 hunks)
  • gomod2nix.toml (2 hunks)
Files skipped from review due to trivial changes (1)
  • go.mod
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...

(IF_VB_PCT)


[misspelling] ~130-~130: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...

(CONFUSION_OF_OR)


[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~179-~179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~192-~192: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~193-~193: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[grammar] ~212-~212: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...

(MISSING_TO_BETWEEN_BE_AND_VB)


[misspelling] ~216-~216: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...

(CLEAN_UP)


[grammar] ~332-~332: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...

(IT_VBZ)


[style] ~399-~399: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~421-~421: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~422-~422: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~423-~423: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~438-~438: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~439-~439: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~440-~440: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~458-~458: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~459-~459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~460-~460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~461-~461: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~467-~467: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~468-~468: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~482-~482: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~483-~483: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~486-~486: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~494-~494: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~495-~495: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~502-~502: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~506-~506: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[grammar] ~626-~626: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...

(IT_VBZ)


[uncategorized] ~664-~664: Possible missing comma found.
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...

(AI_HYDRA_LEO_MISSING_COMMA)

Markdownlint
CHANGELOG.md

54-54: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


66-66: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


74-74: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


82-82: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


90-90: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


91-91: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


92-92: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


96-96: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


104-104: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


105-105: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


106-106: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


107-107: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


108-108: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


109-109: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


113-113: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


114-114: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


120-120: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


121-121: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


122-122: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


123-123: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


124-124: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


128-128: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


129-129: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


130-130: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


131-131: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


132-132: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


133-133: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


137-137: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


138-138: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


139-139: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


140-140: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


141-141: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


142-142: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


146-146: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


147-147: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


148-148: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


156-156: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


157-157: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


161-161: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


169-169: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


170-170: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


171-171: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


172-172: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


173-173: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


174-174: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


175-175: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


176-176: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


177-177: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


178-178: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


179-179: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


180-180: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


181-181: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


182-182: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


183-183: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


184-184: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


185-185: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


186-186: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


187-187: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


188-188: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


189-189: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


190-190: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


191-191: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


192-192: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


193-193: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


197-197: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


198-198: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


199-199: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


200-200: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


201-201: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


202-202: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


203-203: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


204-204: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


205-205: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


206-206: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


207-207: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


208-208: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


209-209: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


210-210: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


211-211: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


212-212: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


216-216: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


217-217: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


218-218: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


219-219: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


220-220: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


221-221: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


222-222: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


223-223: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


227-227: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


228-228: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


229-229: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


230-230: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


231-231: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


232-232: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


233-233: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


234-234: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


235-235: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


236-236: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


237-237: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


238-238: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


239-239: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


240-240: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


241-241: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


242-242: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


243-243: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


244-244: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


245-245: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


246-246: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


247-247: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


248-248: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


249-249: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


250-250: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


251-251: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


259-259: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


260-260: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


261-261: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


265-265: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


266-266: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


267-267: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


268-268: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


269-269: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


270-270: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


271-271: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


279-279: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


287-287: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


291-291: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


292-292: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


293-293: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


301-301: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


305-305: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


306-306: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


307-307: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


315-315: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


323-323: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


331-331: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


332-332: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


341-341: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


349-349: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


357-357: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


365-365: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


366-366: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


367-367: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


368-368: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


376-376: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


384-384: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


385-385: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


393-393: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


397-397: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


398-398: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


399-399: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


407-407: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


419-419: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


420-420: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


421-421: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


422-422: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


423-423: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


424-424: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


425-425: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


429-429: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


430-430: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


431-431: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


435-435: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


436-436: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


437-437: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


438-438: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


439-439: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


440-440: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


448-448: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


456-456: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


457-457: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


458-458: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


459-459: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


460-460: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


461-461: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


465-465: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


466-466: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


467-467: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


468-468: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


476-476: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


477-477: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


478-478: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


479-479: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


480-480: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


481-481: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


482-482: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


483-483: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


484-484: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


485-485: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


486-486: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


487-487: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


491-491: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


492-492: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


493-493: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


494-494: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


495-495: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


499-499: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


500-500: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


501-501: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


502-502: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


503-503: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


504-504: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


505-505: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


506-506: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


514-514: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


515-515: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


523-523: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


531-531: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


532-532: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


533-533: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


537-537: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


538-538: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


546-546: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


547-547: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


548-548: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


549-549: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


550-550: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


558-558: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


562-562: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


563-563: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


564-564: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


565-565: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


575-575: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


579-579: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


580-580: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


581-581: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


582-582: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


586-586: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


587-587: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


598-598: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


599-599: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


600-600: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


601-601: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


602-602: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


606-606: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


607-607: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


608-608: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


618-618: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


619-619: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


630-630: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


634-634: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


635-635: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


636-636: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


637-637: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


638-638: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


639-639: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


641-641: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


642-642: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


650-650: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


654-654: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


658-658: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


668-668: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


669-669: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


670-670: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


671-671: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


677-677: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


678-678: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


682-682: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


40-40: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


48-48: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


60-60: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


68-68: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


76-76: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


84-84: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


98-98: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


116-116: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


150-150: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


163-163: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


253-253: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


273-273: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


281-281: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


295-295: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


309-309: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


317-317: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


325-325: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


335-335: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


343-343: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


351-351: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


359-359: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


370-370: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


378-378: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


387-387: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


401-401: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


409-409: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


413-413: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


442-442: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


450-450: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


470-470: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


508-508: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


517-517: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


525-525: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


540-540: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


552-552: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


567-567: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


589-589: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


610-610: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


621-621: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


644-644: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


660-660: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


28-28: null
No empty links

(MD042, no-empty-links)

Additional comments not posted (3)
gomod2nix.toml (2)

400-402: Approved the addition of github.com/hashicorp/golang-lru/v2.

This new indirect dependency at version v2.0.7 seems to be a part of the updates in this pull request. Please verify that the hash sha256-t1bcXLgrQNOYUVyYEZ0knxcXpsTk4IuJZDjKvyJX75g= is accurate for the provided version.


157-158: Approved the version update for github.com/cometbft/cometbft.

The update from v0.38.7 to v0.38.8 is in line with the objectives to keep the cometbft dependency current. Please ensure the hash sha256-FJ04SP2VDpkvNGRGojaNeuwCqC54Deru244YJERAmi8= correctly matches the version v0.38.8.

CHANGELOG.md (1)

28-28: Update Entry for cometbft Library

The entry correctly notes the update of the cometbft library to version v0.38.8. This aligns with the PR's objective to update this dependency. Make sure this version update is reflected across all documentation and code where this version number is relevant.

Tools
Markdownlint

28-28: null
No empty links

(MD042, no-empty-links)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

Line range hint 21-21: Consider revising the grammar for clarity.

The entry might be clearer with a slight grammatical adjustment:

- Validate e2ee key when register.
+ Validate e2ee key when registering.

Line range hint 130-130: Clarify the intention behind the phrase.

There seems to be a typo or incorrect word usage in the entry. Consider revising it for clarity:

- Update ethermint to fix of avoid redundant parse chainID from gensis when start server.
+ Update ethermint to fix or avoid redundant parsing of chainID from genesis when starting the server.
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f1da23 and e43db5b.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • go.mod (2 hunks)
  • gomod2nix.toml (2 hunks)
Files skipped from review due to trivial changes (1)
  • go.mod
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...

(IF_VB_PCT)


[misspelling] ~130-~130: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...

(CONFUSION_OF_OR)


[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~179-~179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~192-~192: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~193-~193: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[grammar] ~212-~212: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...

(MISSING_TO_BETWEEN_BE_AND_VB)


[misspelling] ~216-~216: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...

(CLEAN_UP)


[grammar] ~332-~332: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...

(IT_VBZ)


[style] ~399-~399: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~421-~421: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~422-~422: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~423-~423: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~438-~438: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~439-~439: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~440-~440: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~458-~458: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~459-~459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~460-~460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~461-~461: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~467-~467: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~468-~468: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~482-~482: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~483-~483: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~486-~486: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~494-~494: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~495-~495: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~502-~502: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~506-~506: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[grammar] ~626-~626: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...

(IT_VBZ)

Markdownlint
CHANGELOG.md

54-54: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


66-66: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


74-74: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


82-82: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


90-90: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


91-91: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


92-92: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


96-96: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


104-104: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


105-105: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


106-106: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


107-107: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


108-108: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


109-109: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


113-113: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


114-114: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


120-120: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


121-121: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


122-122: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


123-123: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


124-124: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


128-128: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


129-129: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


130-130: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


131-131: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


132-132: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


133-133: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


137-137: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


138-138: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


139-139: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


140-140: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


141-141: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


142-142: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


146-146: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


147-147: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


148-148: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


156-156: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


157-157: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


161-161: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


169-169: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


170-170: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


171-171: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


172-172: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


173-173: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


174-174: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


175-175: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


176-176: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


177-177: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


178-178: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


179-179: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


180-180: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


181-181: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


182-182: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


183-183: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


184-184: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


185-185: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


186-186: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


187-187: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


188-188: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


189-189: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


190-190: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


191-191: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


192-192: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


193-193: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


197-197: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


198-198: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


199-199: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


200-200: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


201-201: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


202-202: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


203-203: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


204-204: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


205-205: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


206-206: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


207-207: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


208-208: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


209-209: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


210-210: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


211-211: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


212-212: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


216-216: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


217-217: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


218-218: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


219-219: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


220-220: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


221-221: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


222-222: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


223-223: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


227-227: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


228-228: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


229-229: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


230-230: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


231-231: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


232-232: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


233-233: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


234-234: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


235-235: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


236-236: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


237-237: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


238-238: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


239-239: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


240-240: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


241-241: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


242-242: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


243-243: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


244-244: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


245-245: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


246-246: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


247-247: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


248-248: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


249-249: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


250-250: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


251-251: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


259-259: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


260-260: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


261-261: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


265-265: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


266-266: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


267-267: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


268-268: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


269-269: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


270-270: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


271-271: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


279-279: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


287-287: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


291-291: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


292-292: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


293-293: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


301-301: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


305-305: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


306-306: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


307-307: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


315-315: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


323-323: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


331-331: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


332-332: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


341-341: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


349-349: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


357-357: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


365-365: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


366-366: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


367-367: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


368-368: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


376-376: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


384-384: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


385-385: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


393-393: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


397-397: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


398-398: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


399-399: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


407-407: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


419-419: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


420-420: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


421-421: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


422-422: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


423-423: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


424-424: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


425-425: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


429-429: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


430-430: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


431-431: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


435-435: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


436-436: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


437-437: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


438-438: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


439-439: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


440-440: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


448-448: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


456-456: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


457-457: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


458-458: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


459-459: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


460-460: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


461-461: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


465-465: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


466-466: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


467-467: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


468-468: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


476-476: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


477-477: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


478-478: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


479-479: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


480-480: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


481-481: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


482-482: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


483-483: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


484-484: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


485-485: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


486-486: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


487-487: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


491-491: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


492-492: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


493-493: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


494-494: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


495-495: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


499-499: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


500-500: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


501-501: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


502-502: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


503-503: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


504-504: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


505-505: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


506-506: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


514-514: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


515-515: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


523-523: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


531-531: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


532-532: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


533-533: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


537-537: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


538-538: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


546-546: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


547-547: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


548-548: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


549-549: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


550-550: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


558-558: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


562-562: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


563-563: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


564-564: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


565-565: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


575-575: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


579-579: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


580-580: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


581-581: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


582-582: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


586-586: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


587-587: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


598-598: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


599-599: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


600-600: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


601-601: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


602-602: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


606-606: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


607-607: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


608-608: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


618-618: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


619-619: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


630-630: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


634-634: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


635-635: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


636-636: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


637-637: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


638-638: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


639-639: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


641-641: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


642-642: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


650-650: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


654-654: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


658-658: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


668-668: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


669-669: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


670-670: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


671-671: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


677-677: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


678-678: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


682-682: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


40-40: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


48-48: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


60-60: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


68-68: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


76-76: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


84-84: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


98-98: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


116-116: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


150-150: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


163-163: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


253-253: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


273-273: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


281-281: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


295-295: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


309-309: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


317-317: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


325-325: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


335-335: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


343-343: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


351-351: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


359-359: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


370-370: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


378-378: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


387-387: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


401-401: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


409-409: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


413-413: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


442-442: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


450-450: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


470-470: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


508-508: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


517-517: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


525-525: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


540-540: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


552-552: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


567-567: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


589-589: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


610-610: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


621-621: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


644-644: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


660-660: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Additional comments not posted (4)
gomod2nix.toml (2)

157-158: Approved cometbft update.

The update from v0.38.7 to v0.38.8 for cometbft with the corresponding hash update is correctly implemented.


400-402: New dependency added: golang-lru/v2.

The addition of golang-lru/v2 at version v2.0.7 is noted. Please ensure this new dependency is necessary and assess its impact on the project.

CHANGELOG.md (2)

28-28: Document the update of cometbft clearly.

The changelog correctly documents the update of the cometbft library to version v0.38.8. This aligns with the PR's objective to keep the library up-to-date.


Line range hint 171-171: Enhance readability by varying the sentence structure.

The repetitive sentence beginnings could be rephrased for better readability and to avoid monotony:

- - [cronos#742](https://github.com/crypto-org-chain/cronos/pull/742) Add upgrade handler for v0.8.0-gravity-alpha2.
+ - [cronos#742](https://github.com/crypto-org-chain/cronos/pull/742) Introduced an upgrade handler for v0.8.0-gravity-alpha2.

Consider applying similar changes to other entries listed.

Also applies to: 172-172, 173-173, 174-174, 175-175, 176-176, 177-177, 178-178, 179-179, 180-180, 181-181, 182-182, 183-183, 184-184, 185-185, 186-186, 187-187, 188-188, 189-189, 190-190, 191-191, 192-192, 193-193

@mmsqe mmsqe enabled auto-merge June 28, 2024 01:52
@mmsqe mmsqe added this pull request to the merge queue Jun 28, 2024
Merged via the queue into crypto-org-chain:main with commit 6537ed3 Jun 28, 2024
43 checks passed
@yihuang yihuang deleted the update-cometbft branch June 28, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants